[WIP] initialized pillarenv to base if it is none

[sanket925]

What does this PR do?

What issues does this PR fix or reference?

Fixes

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes/No

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Salt’s Contributor Guide
• Join our Community Discord
• Salt Project YouTube channel
• Community Wiki

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[mattp-]

the implicit default when pillarenv is None means it merges all envs together. this would break that

[frenkye]

+1 on this. Since current behavior doesnt make sense. Sure ended up using salt pillarenv_from_saltenv: True and saltenv is by default base this will switch pillars to base as well.

Maybe iam missing some usecase when merging all pillars make sense when env for them is not set, but this is rather confusing behavior for someone who wanted to try this out.

If this doesn't came to merge maybe at least clarification to docs would be helpfull. Describe that None merge all pillarenvs since the behavior isn't explained there.

pillarenv

Default: None
Isolates the pillar environment on the minion side. This functions the same as the environment setting, but for pillar instead of states.

Source: https://docs.saltproject.io/en/latest/ref/configuration/minion.html#pillarenv