-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Removing support for Python 3.7 and 3.8 from pre-commit #67731
base: 3006.x
Are you sure you want to change the base?
Conversation
@twangboy Allows us to update the requirements dependencies since we don't have to maintain older versions of those dependencies, for example: support Python 3.7 which will have been dropped by a number of dependencies already, but we have to use older versions of those dependencies which are compatible with Python 3.7.. |
Don't know which button I hit to close this prematurely, reopened it |
I am not opposed to this but I also don't see a need to rush it. |
What does this PR do?
Removes support for Python 3.7 and 3.8 from pre-commit and support in generated requirements for those versions of Python
Leaving support for Python 3.9 as this is required at the moment in order to build, that is, build tools/scripts/actions are currently making use of system python, for example: Rocky Linux 9 is using Python 3.9.
What issues does this PR fix or reference?
Fixes #67729
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.