Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Removing support for Python 3.7 and 3.8 from pre-commit #67731

Open
wants to merge 7 commits into
base: 3006.x
Choose a base branch
from

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Feb 12, 2025

What does this PR do?

Removes support for Python 3.7 and 3.8 from pre-commit and support in generated requirements for those versions of Python
Leaving support for Python 3.9 as this is required at the moment in order to build, that is, build tools/scripts/actions are currently making use of system python, for example: Rocky Linux 9 is using Python 3.9.

What issues does this PR fix or reference?

Fixes #67729

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 self-assigned this Feb 12, 2025
@dmurphy18 dmurphy18 requested a review from a team as a code owner February 12, 2025 00:33
@dmurphy18 dmurphy18 added this to the Sulfur v3006.10 milestone Feb 12, 2025
@dmurphy18 dmurphy18 changed the title Removing support for Python 3.7, 3.8 nd 3.9 from pre-commit [3006.x] Removing support for Python 3.7, 3.8 nd 3.9 from pre-commit Feb 12, 2025
@dmurphy18 dmurphy18 added the test:full Run the full test suite label Feb 12, 2025
twangboy
twangboy previously approved these changes Feb 12, 2025
@dmurphy18 dmurphy18 added the test:os:all Run Tests Against ALL OS'es label Feb 12, 2025
@dmurphy18 dmurphy18 requested a review from dwoz February 13, 2025 16:09
@dmurphy18
Copy link
Contributor Author

dmurphy18 commented Feb 13, 2025

@twangboy Allows us to update the requirements dependencies since we don't have to maintain older versions of those dependencies, for example: support Python 3.7 which will have been dropped by a number of dependencies already, but we have to use older versions of those dependencies which are compatible with Python 3.7..
Reduces the footprint that we have to deal with.

@dmurphy18 dmurphy18 closed this Feb 13, 2025
@dmurphy18 dmurphy18 changed the title [3006.x] Removing support for Python 3.7, 3.8 nd 3.9 from pre-commit [3006.x] Removing support for Python 3.7 and 3.8 from pre-commit Feb 13, 2025
@dmurphy18 dmurphy18 reopened this Feb 13, 2025
@dmurphy18
Copy link
Contributor Author

Don't know which button I hit to close this prematurely, reopened it

@dwoz
Copy link
Contributor

dwoz commented Feb 18, 2025

I don't know what the rush is here. I would say we drop support for these older ones once they stop compiling properly. Though we don't support older versions of Python, people still use Salt on older platforms. The current requirements files we compile aren't really a huge overhead and don't hurt us, but would cause a lot of inconvenience to some of our users if they're removed.

I am not opposed to this but I also don't see a need to rush it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite test:os:all Run Tests Against ALL OS'es
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants