Upgrades dotenv and dotenv-exapand with necessary code changes #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Kroeger <[email protected]>
closes #873 closes #876 checks for dotenv-expand's new interface first (introduced in 6.0.0 motdotla/dotenv-expand@14b1f28#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R31) Signed-off-by: Benjamin Kroeger <[email protected]>
JeromeBu
approved these changes
Feb 28, 2022
korziee
approved these changes
Mar 7, 2022
ChrisScheffler
approved these changes
Apr 1, 2022
magick93
approved these changes
Apr 29, 2022
|
Any clue why this does not get merged ? |
|
Hey.. wondered what the status is on this PR? 😊 |
Closed
|
waiting for a review from a maintainer I guess... @littlewhywhat maybe ? |
|
Hi, the fix is released in 6.2.2. I decided to drop support for dotenv-expand lower than 6.0.0. If problems persist or support for lower dotenv-expand is needed, let me know, I'll react asap. I apologise for making all of you wait for so long and thank you very much for being active and creating a fix. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotenv-expand changed their interface with 6.0.0.
This PR makes pg-migrate compatible with the old and new interfaces
closes #873
closes #876
checks for dotenv-expand's new interface first (introduced in 6.0.0)