Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

++node-pg-migrate patch version, fix migrate #1568

Closed
wants to merge 1 commit into from

Conversation

legendarylarry
Copy link
Contributor

Overview

What is the feature?

Fixes npm run migrate up. dotenv-expand changed their interface with 6.0.0 and this breaks the migrate function.

See salsita/node-pg-migrate#880

npm run migrate up

> [email protected] migrate /home/cmr/earthdata-search
> node-pg-migrate "up"

TypeError: dotenvExpand is not a function
    at Object.<anonymous> (/home/cmr/earthdata-search/node_modules/node-pg-migrate/bin/node-pg-migrate:234:5)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
    at internal/main/run_main_module.js:17:47
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] migrate: `node-pg-migrate "up"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] migrate script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/cmr/.npm/_logs/2022-12-22T14_35_25_130Z-debug.log

What is the Solution?

Increment node-pg-migrate to 6.2.2 which incorporates a fixed version of dotenv-expand.

What areas of the application does this impact?

local db migration

Testing

Reproduction steps

Follow README.md

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@macrouch
Copy link
Contributor

macrouch commented Feb 2, 2023

Closing due to inactivity

@macrouch macrouch closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants