Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Adaptive softmax fixes (#1) #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adaptive softmax fixes (#1) #63

wants to merge 1 commit into from

Conversation

amirsaffari
Copy link

  • Majority of the code is Python 3 compatible
  • Majority of the code runs on CPU if we don't have CUDA command line argument specified and no GPU available
  • The pointer and finetune are now compatible with adaptive softmax
  • The SplitCrossEntropy now correctly returns logprobs for cases where there are no splits
  • ISSUES: finetune still does not work properly, so needs further investigations

@amirsaffari
Adaptive softmax fixes (#1)
129d2e9 
* adding Python 3 and other fixes to make pointer and finetune compatible

* further fixes to pointer

* open now should work in Python2
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @amirsaffari to sign the Salesforce.com Contributor License Agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@amirsaffari