Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dimonina] make combineQueries strongly typed #733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dimonina
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

combineQueries method is not providing types down to the pipe as combineLatest does

What is the new behavior?

combineQueries now copies a signature of combineLatest method with the ability for typescript to calculate types down to the pipe

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Dimonina Dimonina changed the title combineQueries is not strongly typed [Dimonina] make combineQueries strongly typed Aug 18, 2021
@NetanelBasal
Copy link
Collaborator

Can you show an example, please? It seems to have worked.

@tony
Copy link
Contributor

tony commented Jun 11, 2022

@Dimonina Can you rebase and provide some examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants