Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10482 - No update importable property when republishing module in constructor #10642

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

ssamko0911
Copy link

@ssamko0911 ssamko0911 commented Mar 11, 2025

Description

See the issue: #10484
+
The 'Deploy' option in the ModuleBuilder identifies the same behaviour.

Motivation and Context

To make redeployment work.
I'd go for the use of named arguments in this case, but composer.json still points to PHP 7.4

How To Test This

See the issue: #10484

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@mattlorimer mattlorimer added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member PR 1-3 Complexity Score given to PRs once assessed labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR 1-3 Complexity Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants