-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 10547 - Incorrect visualization of task due date on subpanels #10548
base: hotfix
Are you sure you want to change the base?
Conversation
Hello @SinergiaCRM, thanks again for contributing, would you be so kind to update the commit text and link it to the actual issue? Thanks a lot! Regards, |
d97f2da
to
9392cbc
Compare
Done @serhiisamko091184 |
Hello @SinergiaCRM, thanks a lot for the quick reply and changes done! Regards, |
Hey! If a subpanel has multiple Meetings or Calls, it appears to now only show the Due Date of the top-most rendered Meeting/Call. See screenshots. Could you have a look at this when you get a chance? (Or please let me know if you need any further information!) |
Hi @johnM2401, |
Hi @SinergiaCRM Great, thank you for confirming this Thanks again! |
Hi @johnM2401 , |
Description
Fixing #10547
When visualizing more than one task row on the activities subpanel (of Contact for instance), the second row had the due date incorrectly formatted.
The problem was that on second record, for alias fields, $aItem->field_defs contains the field definition, but field_name_map does not have the type information.
The solution has been to apply to second and following rows the same treatment as the first row
Motivation and Context
Motivation: Due date was being incorrectly formatted on some records
How To Test This
Types of changes
Final checklist