Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10547 - Incorrect visualization of task due date on subpanels #10548

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

Fixing #10547
When visualizing more than one task row on the activities subpanel (of Contact for instance), the second row had the due date incorrectly formatted.
The problem was that on second record, for alias fields, $aItem->field_defs contains the field definition, but field_name_map does not have the type information.
The solution has been to apply to second and following rows the same treatment as the first row

Motivation and Context

Motivation: Due date was being incorrectly formatted on some records

How To Test This

  1. Create more than one task with due date informed from the activities subpanel of any contact
  2. Check that all due dates are formatted consistently

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks again for contributing,

would you be so kind to update the commit text and link it to the actual issue?
image

Thanks a lot!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Oct 14, 2024
@enricsinergia
Copy link

Hello @SinergiaCRM,

thanks again for contributing,

would you be so kind to update the commit text and link it to the actual issue? image

Thanks a lot!

Regards, Serhii

Done @serhiisamko091184

@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks a lot for the quick reply and changes done!

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed Status: Requires Code Review Needs the core team to code review and removed Status:Requires Updates Issues & PRs which requires input or update from the author labels Oct 21, 2024
@serhiisamko091184 serhiisamko091184 added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Oct 24, 2024
@johnM2401 johnM2401 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Dec 16, 2024
@johnM2401
Copy link
Contributor

Hey!
This fix looks good for Tasks, however it appears to have caused some issues with Meetings/Calls.

If a subpanel has multiple Meetings or Calls, it appears to now only show the Due Date of the top-most rendered Meeting/Call.

See screenshots.

Before fix:
image

After Fix:
image

Could you have a look at this when you get a chance? (Or please let me know if you need any further information!)
Thank you again for your contributions!

@SinergiaCRM
Copy link
Contributor Author

Hi @johnM2401,
I have been able to replicate the error you describe. I was not getting it because we have previous changes on the codebase that are included in a previous PR: #9519

@johnM2401
Copy link
Contributor

Hi @SinergiaCRM

Great, thank you for confirming this
Please let me know if I can provide any further info!

Thanks again!

@SinergiaCRM
Copy link
Contributor Author

Hi @SinergiaCRM

Great, thank you for confirming this Please let me know if I can provide any further info!

Thanks again!

Hi @johnM2401 ,
it would be great if the previous PR can be included before. It was approved a year ago (and solves another issue with the activities subpanel) but no more news have come after that. Without that changes, the changes in this PR should be reworked, and reworked again if that PR is ever merged. So the best scenario would be to include both PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Requires Testing Requires Manual Testing Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants