Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address file upload issue caused by missing socket subscription #1206

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Address file upload issue caused by missing socket subscription #1206

merged 1 commit into from
Jan 31, 2025

Conversation

igorkravchenko
Copy link
Contributor

MOB-3993

What was solved?
Fix file upload issue by calling 'TranscriptModel.start'.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@igorkravchenko igorkravchenko requested a review from a team as a code owner January 30, 2025 17:57
@igorkravchenko igorkravchenko force-pushed the fix/MOB-3993-address-sc-file-upload-issue branch from 5d8085e to f058eab Compare January 30, 2025 19:06
EgorovEI
EgorovEI approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@EgorovEI EgorovEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix swiftlint warnings in TranscriptModel.swift

@igorkravchenko
Copy link
Contributor Author

!squash

@igorkravchenko
Address file upload issue caused by missing socket subscription
5b985b8 
Fix file upload issue by calling 'TranscriptModel.start'.

MOB-3993
@sm-deployer sm-deployer force-pushed the fix/MOB-3993-address-sc-file-upload-issue branch from befac84 to 5b985b8 Compare January 31, 2025 15:46
@igorkravchenko igorkravchenko merged commit bcfb231 into feature/entry-widget-and-secure-conversations-v2 Jan 31, 2025
8 checks passed
@igorkravchenko igorkravchenko deleted the fix/MOB-3993-address-sc-file-upload-issue branch January 31, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykyivskyi-gl ykyivskyi-gl ykyivskyi-gl approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorkravchenko @EgorovEI @ykyivskyi-gl