Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace InteractorProviding with InteractorPublisher #1198

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Replace InteractorProviding with InteractorPublisher #1198

merged 1 commit into from
Jan 31, 2025

Conversation

rasmustautsglia
Copy link
Contributor

What was solved?
After Interactor was refactored to be Published property, interactorProviding was replaced with interactorPublisher using Combine

MOB-3982

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@rasmustautsglia rasmustautsglia requested a review from a team as a code owner January 28, 2025 14:33
igorkravchenko
igorkravchenko reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some comment about possibility of nil interactor and suggestions regarding removing self where its optional version is guarded.

GliaWidgets/SecureConversations/SecureConversations.PendingInteraction.swift Show resolved Hide resolved
GliaWidgets/SecureConversations/SecureConversations.PendingInteraction.swift Outdated Show resolved Hide resolved
GliaWidgets/Sources/CallVisualizer/CallVisualizer.swift Outdated Show resolved Hide resolved
GliaWidgets/Sources/CallVisualizer/CallVisualizer.swift Outdated Show resolved Hide resolved
GliaWidgets/Sources/CallVisualizer/CallVisualizer.swift Outdated Show resolved Hide resolved
@rasmustautsglia
Copy link
Contributor Author

!squash

@rasmustautsglia
Replace InteractorProviding with InteractorPublisher
ef16303 
After Interactor was refactored to be Published property, interactorProviding was replaced with interactorPublisher using Combine

MOB-3982
@sm-deployer sm-deployer force-pushed the Replace-InteractorProviding-with-InteractorPublisher branch from b1ed392 to ef16303 Compare January 31, 2025 09:32
@rasmustautsglia rasmustautsglia merged commit a718cac into feature/entry-widget-and-secure-conversations-v2 Jan 31, 2025
8 checks passed
@rasmustautsglia rasmustautsglia deleted the Replace-InteractorProviding-with-InteractorPublisher branch January 31, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrii-Horishnii-Glia Andrii-Horishnii-Glia Andrii-Horishnii-Glia approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@ykyivskyi-gl ykyivskyi-gl Awaiting requested review from ykyivskyi-gl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rasmustautsglia @igorkravchenko @EgorovEI @Andrii-Horishnii-Glia