Fix use after free. #403
Open
Fix use after free. #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the function libusb_free_transfer, the transfer object is freed and then on the next line transfer->user_data is set to NULL. This caused random heap corruption, and the assignment seems redundant as the object is no longer in use.
mtdxc
pushed a commit
to mtdxc/UVCCamera
that referenced
this pull request
Nov 24, 2023
mtdxc
pushed a commit
to mtdxc/UVCCamera
that referenced
this pull request
Nov 27, 2023
mtdxc
pushed a commit
to mtdxc/UVCCamera
that referenced
this pull request
Nov 28, 2023
mtdxc
pushed a commit
to mtdxc/UVCCamera
that referenced
this pull request
Nov 28, 2023
mtdxc
pushed a commit
to mtdxc/UVCCamera
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function libusb_free_transfer, the transfer object is freed and then on the next line transfer->user_data is set to NULL.
This caused random heap corruption, and the assignment seems redundant as the object is no longer in use.