Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-48943 Lessons adding new embed code does not update the current video #13300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

st-manu
Copy link
Contributor

@st-manu st-manu commented Feb 12, 2025

https://sakaiproject.atlassian.net/browse/SAK-48943

isImageType calls getExtension, but for scripts, there's no filename, causing a NullPointerException

…g new embed code does not update the current video
@ottenhoff ottenhoff requested a review from ern February 12, 2025 16:40
@ern ern changed the title SAK-48943 Lessons: Embed content > URL/embed code and editing > adding new embed code does not update the current video SAK-48943 Lessons adding new embed code does not update the current video Feb 20, 2025
@ern
Copy link
Contributor

ern commented Feb 20, 2025

@st-manu what do you think of something simpler, like:

public static String getExtension(String name) {
    String extension = org.springframework.util.StringUtils.getFilenameExtension(name);
    return StringUtils.trimToEmpty(extension).toLowerCase();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants