Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-50725 Samigo calculated question fails if ampersand character exists in the text #13074

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

st-manu
Copy link
Contributor

@st-manu st-manu commented Dec 2, 2024

https://sakaiproject.atlassian.net/browse/SAK-50725

Test & Quizzes fail when a calculated question contains an @ symbol in the question body used for something other than a global variable.

Copy link
Contributor

@ottenhoff ottenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test! There are lots of tests already in place and patterns you can repeat.

@st-manu
Copy link
Contributor Author

st-manu commented Dec 3, 2024

test added ✅ @ottenhoff

Copy link
Contributor

@ottenhoff ottenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job with the tests!!

@ern ern changed the title SAK-50725 Tests & Quizzes: Calculated Question fails if the @ character exists in the text SAK-50725 Samigo calculated question fails if ampersand character exists in the text Dec 3, 2024
@ern ern merged commit 6a8de33 into sakaiproject:master Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants