Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-48501 Site Manage use a proper date/time format #13072

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

maurercw
Copy link
Contributor

@maurercw maurercw commented Dec 1, 2024

…entation so that we can ensure it's properly parsed

@@ -2656,6 +2658,7 @@ else if (state.getAttribute(STATE_CM_REQUESTED_SECTIONS) != null) {
if(daysafter > 0){
context.put("daysafter",daysafter);
}
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but I believe you could just use withZone here and avoid having to do atZone later. And might also be "nice to have" to have it final. I'm fine with your preference if you tested this to work. Thanks for the fix!

final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss").withZone(localZoneId);

@ern ern changed the title SAK-48501 - Site Manage: Use a legit date/time format instead of a toString repres… SAK-48501 Site Manage use a proper date/time format Dec 3, 2024
@ottenhoff ottenhoff merged commit 815939d into sakaiproject:master Dec 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants