SAK-50610 conversations Integrate with gradebook #13064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
webcomponents/tool/src/main/frontend/packages/sakai-editor/src/SakaiEditor.js
Show resolved
Hide resolved
|
jesusmmp
reviewed
Nov 27, 2024
| try { | ||
| return conversationsService.saveTopic(topicBean, false); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
It's just a unit test. I usually use printStackTrace if it is not an expected exception.
ottenhoff
reviewed
Nov 27, 2024
| @@ -55,7 +55,7 @@ | |||
| "eslint-plugin-html": "^8.1.2", | |||
| "eslint-plugin-lit": "^1.15.0", | |||
| "eslint-plugin-wc": "^2.2.0", | |||
| "fetch-mock": "^12.0.2", | |||
| "fetch-mock": "^9.11.0", | |||
There was a problem hiding this comment.
Yes it was on purpose. The tests are broken because the latest fetch mock needs to be imported in a different fashion. Serious breaking changes between 9 and 12.
|
wow awesome feature. thank you! |
ottenhoff
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50610