SAK-50645 Lessons misplaced items when added to the page #12990
Conversation
| @@ -3290,6 +3290,7 @@ function buttonOpenDropdowna() { | |||
| addAboveItem = addAboveLI.find("span.itemid").text(); | |||
| $(".addbreak").show(); | |||
| openDropdown($("#addContentDiv"), $("#dropdownc"), msg('simplepage.add-above')); | |||
| $("#addContentDiv button.btn-close").click(closeDropdown); | |||
There was a problem hiding this comment.
what exactly is this doing? my read is that you are attaching a new click handler to this button.btn-close so that the next time it is clicked, it will call the closeDropdown function. is that your intent?
There was a problem hiding this comment.
Yes, we need the modal's close button when clicked to clean up (reinitialize) some var settings occurring when the Add Content 'above this item' modal or the Add Content 'at the bottom of this section' modal is opened.
Fwiw, the rationale for the function name "closeDropdown" is borrowed from show-page.js naming used in Sakai 21/22 for similar intents.
I'm open to suggestions. How would you like to proceed?
There was a problem hiding this comment.
Yes, we need the modal's close button when clicked ...
What about when it's not clicked, and the user instead uses escape to close it out?
Fwiw, the rationale for the function name "closeDropdown" is borrowed from show-page.js naming used in Sakai 21/22 for similar intents.
I would recommend just using clear method naming instead of trying to re-use old naming.
I'm open to suggestions. How would you like to proceed?
I don't know this code. But can you cleanup somewhere else? Can you just clean these vars in openDropdown instead?
There was a problem hiding this comment.
Trying to capture the various other closing events (something I obviously overlooked in hindsight) was more complicated than readding an explicit 'open' function for the main 'Add Content' button. Thus, I've since proceeded with the latter approach.
There was a problem hiding this comment.
Since porting this new commit to my local instance of 23.x and testing there, I'm finding some problems. I'll revert this to draft until I can resolve those issues.
There was a problem hiding this comment.
Seems that I was missing id="addcontent" from the relevant button in ShowPage.html.
(What has me still somewhat scratching my head though is that I thought I had seen that id attribute for this button present in the DOM without my explicitly adding it. Now however I can't locate where it might be sourced... whether via ShowPage.html, show-page.js, or ShowPageProducer.java.)
hornersa
force-pushed
the
SAK-50645
branch
2 times, most recently
from
e211485
to
7bbfc33
Compare
ern
changed the title
Jira: https://sakaiproject.atlassian.net/browse/SAK-50645
Refer to videos attached to the jira which demo the bug and the proposed fix.