Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49285 msgcntr return persisted entity in private forums #11916

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

jesusmmp
Copy link
Contributor

@jesusmmp jesusmmp marked this pull request as draft September 19, 2023 09:37
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesusmmp looks pretty good just a few minor suggestions

@ottenhoff
Copy link
Contributor

@jesusmmp are you interested in getting this merged?

@jesusmmp
Copy link
Contributor Author

I'll fix this PR in the summer

@ern ern changed the title SAK-49285 Restriction unique violated SYS_C00508178 SAK-49285 msgcntr oracle restriction unique violated SYS_C00508178 Jun 3, 2024
@jesusmmp jesusmmp force-pushed the SAK-49285 branch 3 times, most recently from b531388 to d0c9e5a Compare June 10, 2024 07:45
@jesusmmp
Copy link
Contributor Author

Pending of some testing.

@jesusmmp jesusmmp force-pushed the SAK-49285 branch 3 times, most recently from 78710d0 to a770938 Compare June 11, 2024 10:53
@jesusmmp jesusmmp marked this pull request as ready for review June 11, 2024 11:09
@ern
Copy link
Contributor

ern commented Jun 11, 2024

@jesusmmp will give an update next week on this

@jesusmmp
Copy link
Contributor Author

Merged on our production instance: 06/18/24

@jesusmmp
Copy link
Contributor Author

Reverted 06/19/24
Pending of some fixes.

@jesusmmp
Copy link
Contributor Author

Merged on our production instance: 06/24/24

@ern ern changed the title SAK-49285 msgcntr oracle restriction unique violated SYS_C00508178 SAK-49285 msgcntr return persisted entity in private forums Jul 2, 2024
@ern ern merged commit 5c68cf8 into sakaiproject:master Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants