Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary/incorrect steps from README #205

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rfdonnelly
Copy link

There is no need to modify the provided wsl-vpnkit.service and the cp command is made redundant by the prior tee command.

The cp command references a non-existent path and is made unnecessary by the prior tee command.  Fix by removing the cp command.

It is unclear why one might need/want to edit the provided `wsl-vpnkit.service` file.  Remove the edit command to prevent confusion.
@rfdonnelly
Copy link
Author

I see my confusion now. The two blocks were "either/or" instead of "and". This PR removes the confusion by eliminating one of the options.

@sakai135
Copy link
Owner

@rfdonnelly Thanks, this is a part that I do need to clarify since I've had similar comments before as well. One is supposed to be for people that are running the wsl-vpnkit in the provided distro, and the other is supposed to be for people that are running it as a stand-alone script.

@rfdonnelly
Copy link
Author

@sakai135 please feel free to close if you'd like to resolve differently. Much thanks for your work on this project.

@K2ouMais
Copy link

K2ouMais commented Jun 1, 2023

The README is really confusing...

Maybe you could provide a section on how to run it as a standalone wsl distro and another section for people that want to run it as systemd service on the already installed and choosen wsl distro.

@davea38
Copy link

davea38 commented Aug 3, 2023

The README is really confusing...

Maybe you could provide a section on how to run it as a standalone wsl distro and another section for people that want to run it as systemd service on the already installed and choosen wsl distro.

+1 for this - it should be divided into two sections and each section should be self contained. The current README is terribad (sorry!)

@GF-Huang
Copy link

Sorry guys, I got tee not found, can someone help me?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants