-
Notifications
You must be signed in to change notification settings - Fork 244
sync upstream #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimpepper
wants to merge
91
commits into
sajari:master
Choose a base branch
from
skpr:sync-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
sync upstream #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
commented
Dec 4, 2025
- Update build approach for Alpine
- Build for multiple architectures
- Update CirlceCI
- Enable Docker experimental features
- Enable Docker experimental features
- Updated config.yml
- Fix bin path
- Fix bin path
- Rebuild
- Bump to Alpine 3.17 (Issue sajari/sjengine-v9#185. Added readability to HTML conversion #2)
- Reinstate Golang 1.19
- Bump deps. Only build/push Alpine 3.17/3.18
- chore: update go version to 1.23 and all dependencies (If no file provided defer file.Close() causes panic. #6)
- Bump to Go 1.24 (Support .pages files #8)
* Bump to Alpine 3.17 * Build on PR. * Bump to Go 1.20 --------- Co-authored-by: Nick Schuch <[email protected]>
Co-authored-by: Nick Schuch <[email protected]>
* Bump to Go 1.24 * Remove Alpine 3.19
Also update README GoDoc badge to pkg.go.dev.
In [1], from Go1.15 path separators are rejected in ioutil.TempFile. Refs sajari#87 [1] golang/go@12cd55c
Co-authored-by: Andrea Mugellini <[email protected]>
Also show Go version in startup logs.
- Some methods have been changed to return an error as their last argument - Log calls inside various functions have been removed - Use a v1 tag if you need the previous signature
Example log entry that is panicking: > could not write to response (failed after 3965 bytes): write tcp 172.17.0.5:8080->172.17.0.4:61528: write: broken pipe
See [my race fix PR]. Saw the issue in our logs, so using our fork for now. [my race fix PR]: richardlehane/msoleps#6
* Limit the size of the content type definition in OOXML * Improve naming in OOXML tests * Check OOXML error type in tests
* Bump to Alpine 3.17 * Build on PR. * Bump to Go 1.20 --------- Co-authored-by: Nick Schuch <[email protected]>
* Bump to Go 1.24 * Remove Alpine 3.19
e7871c7 to
fdec8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.