Skip to content

Conversation

@elsteveogrande
Copy link

@nmd1 nmd1 mentioned this pull request Feb 16, 2020
have_stringio = True
except ImportError:
pass
assert have_stringio and "no StringIO package available"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cleaner to have the error string after a comma instead of abusing boolean operators...

Copy link

@jibanes jibanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated

@lubosz
Copy link

lubosz commented Oct 16, 2023

You should not edit sixel_impl.c manually, but regenerate it with:

cython sixel/converter.py -o sixel/sixel_cimpl.c

As seen in the Makefile.

Also the StringIO import should be just the one from the Python 3 standard library, without the balancing act.

For a working fork of this, check out my repo:
https://github.com/lubosz/PySixel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants