Fix EAGAIN check in smb2_read_data #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU defines
EAGAIN
andEWOULDBLOCK
as the same value but notes both values should be checked for portability.This resolves a
Read from socket failed
issue introduced when building with non-GNU environments that define EAGAIN and EWOULDBLOCK as separate, distinct values.As noted in the GNU libc documentation under 2.2 Error Codes.
This patch corrects the check in
smb2_read_data
that could fail under aread_more_data
goto and a socket read that returnsEWOULDBLOCK
.Similar checks already appear in the
libsmb2
codebase.libsmb2/lib/socket.c
Line 277 in c88fe13