Add Nintendo WII, Nintendo Gamecube, Nintendo DS and Nintnedo WII-U support. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Nintendo DevkitPro ports. Includes: Nintendo WII Nintendo WII-U Nintendo GameCube Nintendo DS
|
Port done by me. |
Wolf3s
changed the title
Wolf3s
force-pushed
the
nintendo
branch
2 times, most recently
from
fe6ec58
to
e499ee3
Compare
Remove Nintendo Switch hack. Separate gamecube from wii in README. Remove HAVE_SYS__IOVEC_H
Wolf3s
force-pushed
the
nintendo
branch
5 times, most recently
from
940b0b9
to
4954c00
Compare
sahlberg
reviewed
May 29, 2024
| } else if (getsockopt(fd, SOL_SOCKET, SO_ERROR, | ||
| (char *)&err, &err_size) != 0 || err != 0) { | ||
| #ifdef __GC__ | ||
| } else if (getsockopt(fd, SOL_SOCKET, SO_ERROR, (char *)&err, err_size) != 0 || err != 0) { |
There was a problem hiding this comment.
This should probably be turned into a getsockopt() replacement in compat.c but there are only two places so no need to worry about it for now.
There was a problem hiding this comment.
Hey there sorry for this, but unfortunally this implementation doesn't take the * parameter maybe i will do in a future update remove this and add convert cast to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.