Skip to content

Annoate methods with Self #40235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

Annoate methods with Self #40235

merged 1 commit into from
Jun 14, 2025

Conversation

tobiasdiez
Copy link
Contributor

Wanting to join the annoate-return-types-club, some methods that return self are annoted by typing.Self.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jun 9, 2025

Documentation preview for this PR (built with commit c8c9eab; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobiasdiez
Copy link
Contributor Author

Thanks for the quick review!

@vbraun vbraun merged commit c81c2ab into sagemath:develop Jun 14, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants