Remove compilation dependency of rings/convert/mpfi on cypari2
#40231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 31147b7; changes) is ready! 🎉 |
dimpase
reviewed
Jun 10, 2025
|
|
||
| _RIFtol: 'RealIntervalField | None' = None |
There was a problem hiding this comment.
I've never seen this Python syntax - what does it do?
There was a problem hiding this comment.
Yes, it's a type annotation!
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 13, 2025
sagemathgh-40231: Remove compilation dependency of `rings/convert/mpfi` on cypari2 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Make it possible to compile `rings/convert/mpfi` without cypari2 installed. Needed for windows support. Also fail if RealIntervalField cannot be imported, instead of only issuing a warning (since the relevant doctests will fail anyway, there is little point in not failing early). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40231 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to compile
rings/convert/mpfiwithout cypari2 installed. Needed for windows support.Also fail if RealIntervalField cannot be imported, instead of only issuing a warning (since the relevant doctests will fail anyway, there is little point in not failing early).
📝 Checklist
⌛ Dependencies