Declare func(void), fix two related errors #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the C language, a function that accepts no arguments should be declared as func(void), not func(); the latter declares a function that may accept any number of arguments of any type. The func() declarations hid two errors: - getOffendingModifiersMask() was invoked with an extra parameter (placed onto the stack by the caller and then ignored by the function) - pngReadToDrawable_test() was declared without its `pngfile` parameter
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for your continued work on alttab! What do you think about this change that fixes the build with GCC 15.x? (a non-urgent Debian bug was filed about that: https://bugs.debian.org/1096301)
In the C language, a function that accepts no arguments should be declared as func(void), not func(); the latter declares a function that may accept any number of arguments of any type.
The func() declarations hid two errors:
pngfileparameterThanks in advance for your time, and keep up the great work!