Lib should not have allowbakup attribute #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove android:allowBackup="true" from AndroidManifest file as it is giving Manifest merger issues with the application manifest file and the other libraries Manifest file. It's not necessary for your lib. Error seems like: "Manifest merger failed : Attribute application@allowBackup value=(false)". Thank you very much for the great lib.
|
i just want to change the color of indicators . |
|
@savitasudan please merge this change with master branch, and update the gradle dependency version, so I can start to use your lib in my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove android:allowBackup="true" from AndroidManifest file as it is giving Manifest merger issues with the application manifest file and the other libraries Manifest file. It's not necessary for your lib.
Error seems like: "Manifest merger failed : Attribute application@allowBackup value=(false)".
Thank you very much for the great lib.