Merge performance enhancements and some small bugfixes, from stripwax 1.20 release #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bool, make a bunch of other things bool for consistency. Slightly simplifies pause handling and a small reduction in firmware size.
…ruid) require this; I'll need to find another way to stop the buzz at eof
… also make it more sensitive. Also removed some old unused section of the main loop that checked buttons but didn't do anything with them.
…he correct fix for periodic clicking during long pause blocks)
Merge processing improvements to master
…rd show up as a usb storage device when plugged in via cable
…ed1306) printtext. and add new scrolling mode, where text stops at the end of its scroll and starts at the beginning. Also removed some unused data (presumably left over from old variants)
…arlier commit - needed for AVR (at least while our Display.ino does not handle __FlashStringHelper natively)
…e compiler warning)
1. remove oric-specific buffer and function that was only used in one place (and reusing ReadByte instead) 2. removing redundancy and code duplication in the checkForExt functions 3. removing redundancy and code duplication across the Counter1, Counter2, lcdTime functions 4. replace some ints with bytes 5. move some local 'temporary buffers' outside of functions and reuse (the 'out' buffer for the ReadXxxx functions and the fileheader buffer for tzx and ay) 6. remove some unused global variables Firmware image size for Arduino Uno build was checked after every change to confirm size reduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.