Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component for project experience #700

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

erinchen01
Copy link

image This feature was made in collaboration with @ltyagi111111

Description

We added a new component to the home page that showcases users' projects in a style consistent with the rest of the website. Users can access this section by either clicking on the header or scrolling down the web page. Please take a look and let us know if more changes are wanted @saadpasta. Thank you.

Fixes #699

Type of change

We introduced a new component called projectCard.js along with its corresponding styles in projectCard.scss, located in the src/components/projectCard directory. As users scroll through the website, they will find a dedicated projects section within the "Experience" area. To update the content in this section, users should modify the projectExperiences constant in src/portfolio.js. Additionally, we've added a reference to this section in the header. Clicking on "Project Experiences" will direct users to the project section.

  • New feature (non-breaking change which adds functionality)

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-folio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 8:14pm

@AhsanAyaz
Copy link
Collaborator

@Ella-ch thanks for the PR. I don't particularly see the value added by this PR. We already have an "Experiences" section, and we have a "Big Projects" section. What you've added seems more aligned with "Experiences" and it already exists. I think it is great that you can customize this. But I don't particularly see the value in adding it to developer folio's template.
@saadpasta , your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Component for Projects
2 participants