Scoring: Use N/A for recommended/optional, 0 is only a failure for Mandatory #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
commented
Oct 10, 2023
| :1 Sufficient: The TRE meets this requirement met but there is substantial scope for improvement | ||
| :2 Satisfied: The TRE meets this requirement met but there may still be scope for improvement | ||
| :N/A: Not applicable: The statement is not relevant to a TRE, may apply to **Recommended** or **Optional** statements |
There was a problem hiding this comment.
Note if we return to #272 and use conditional Mandatory statements this will need to be updated, AFAIK currently all Mandatory statements are mandatory for all.
There was a problem hiding this comment.
I think this is right, there's probably statements in out eval where we gave ourselves a 2 and just said "we pass because it's not applicable" - I don't think this is a huge issue though
edwardchalstrey1
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
☑️ Maintainers' checklist
Clarifies the scoring system:
0is only a SATRE failure for MandatoryN/Ashould be used if a statement is not relevant🌂 Related issues
Closes #290
🙋 Acknowledging contributors