Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spider golint errors #119

Open
wants to merge 8 commits into
base: onionscan-0.3
Choose a base branch
from

Conversation

onefrankguy
Copy link

This is a step towards #102. It fixes the golint errors in the spider code.

@s-rah
Copy link
Owner

s-rah commented Jan 21, 2017

Thanks! Can you run gofmt -s -w ./... across this code? Looks like something is causing the travis scripts to not like this commit because of the formating - once that is done i'll merge it in!

@onefrankguy
Copy link
Author

Hmm... Running gofmt didn't look like it changed anything. When I run the tests locally, I get an error.

cd $GOPATH/src/s-rah/onionscan
go clean -i -r
./tests.sh

# github.com/s-rah/onionscan/protocol
protocol/ricochet_scanner.go:134: undefined: goricochet.Ricochet

That looks like the same error that's on Travis CI.

Switching go-richochet to the 0.1 tag gets me further.

cd $GOPATH/src/s-rah/go-ricochet
git checkout 0.1

cd $GOPATH/src/s-rah/onionscan
go clean -i -r
./tests.sh

<lots of test output>

And I now have a "coverage.out" file.

This is my first time writing Go code, and I'm not sure where to go from here to fix this.

@s-rah
Copy link
Owner

s-rah commented Jan 22, 2017

Ah Sorry, this is my fault - I misread the output. There is some work going on in the go-ricochet package and it looks like it has broken an interface here.I'll find some time to fix up the changes this week and then once the 0.3 branch is working again I will merge this in.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants