Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sliding window operator #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement sliding window operator #207

wants to merge 1 commit into from

Conversation

AntonOellerer
Copy link
Contributor

I implemented this since I needed it for my thesis, it is not part of
the standard, and I don't know whether it is any good, but I thought
I might as well open a PR with it, just close it if it is unneeded.

The function sliding_window(window_size, scanning_interval, time_function, scheduler)
emits each scanning_interval a Vec which contains all elements
having a timestamp time_function(T) larger than
now() - window_size.
This means that each item can occur in multiple vectors if
window_size > scanning_interval.

@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2022

Welcome to rxRust!
We're delighted to have you onboard <3

@AntonOellerer AntonOellerer force-pushed the feature/sliding_window_operator branch 2 times, most recently from 5446267 to b039005 Compare December 30, 2022 13:41
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2022

Clippy helps us to improve our Rust code. Could you fix it? 🙏 Run cargo clippy --all-targets --all-features -- -D warnings to get more details.

@codecov
Copy link

codecov bot commented Dec 30, 2022 •
edited

Codecov Report

Base: 94.27% // Head: 94.35% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (2eff6cf) compared to base (0ddd72c).
Patch coverage: 97.24% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   94.27%   94.35%   +0.07%     
==========================================
  Files          67       68       +1     
  Lines        5347     5491     +144     
==========================================
+ Hits         5041     5181     +140     
- Misses        306      310       +4
Impacted Files Coverage Δ
src/ops.rs 100.00% <ø> (ø)
src/ops/sliding_window.rs 97.16% <97.16%> (ø)
src/lib.rs 87.81% <100.00%> (ø)
src/observable.rs 95.10% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AntonOellerer
Implement sliding window operator
2eff6cf 
The function `sliding_window(window_size, scanning_interval,
 time_function, scheduler)`
emits each `scanning_interval` a Vec<T> which contains all elements
 having a timestamp `time_function(T)` larger than
 `now() - window_size`.
This means that each item can occur in multiple vectors if
 `window_size > scanning_interval`.
@AntonOellerer AntonOellerer force-pushed the feature/sliding_window_operator branch from b039005 to 2eff6cf Compare January 2, 2023 13:22
@mergify
Copy link
Contributor

mergify bot commented Jan 2, 2023

Clippy helps us to improve our Rust code. Could you fix it? 🙏 Run cargo clippy --all-targets --all-features -- -D warnings to get more details.

@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2023

This pull request now has unresolved conflicts. Could you fix it? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AntonOellerer