Upgrade flutter to version 3.22 #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmephil
reviewed
Jun 11, 2024
example/pubspec.yaml
Outdated
| @@ -31,11 +32,11 @@ dependencies: | |||
| sdk: flutter | |||
|
|
|||
| flutter_audio_waveforms: | |||
| path: /Users/rutviktak/flutter_projects/flutter_plugins/flutter_audio_waveforms/ # 1.0.0+1 | |||
| path: /home/wolverine/projects/flutter-projects/flutter packages/flutter_audio_waveforms | |||
There was a problem hiding this comment.
This is pointing to your machine path, try reverting this to the old one.
example/web/index.html
Outdated
| @@ -34,7 +34,7 @@ | |||
| application. For more information, see: | |||
| https://developers.google.com/web/fundamentals/primers/service-workers --> | |||
| <script> | |||
| var serviceWorkerVersion = null; | |||
| var serviceWorkerVersion = '{{flutter_service_worker_version}}'; | |||
There was a problem hiding this comment.
This is no longer a valid script tag as of Flutter 3.2X
...
<link rel="manifest" href="manifest.json" />
</head>
<body>
<script src="flutter_bootstrap.js" async></script>
</body>
example/lib/waveforms_dashboard.dart
Outdated
| int maxDurationInmilliseconds = | ||
| await audioPlayer.fixedPlayer!.getDuration(); | ||
| await audioPlayer.getDuration() | ||
| .then((value) => maxDuration = value!); |
There was a problem hiding this comment.
It's not safe to bang! a better approach would be to set a default duration to 0.
maxDuration = value ?? Duration.zero
example/lib/main.dart
Outdated
| int maxDurationInmilliseconds = | ||
| await audioPlayer.fixedPlayer!.getDuration(); | ||
| await audioPlayer.getDuration().then((value) => | ||
| maxDuration = value!); |
There was a problem hiding this comment.
It's not safe to bang! A better approach would be to set the default value to 0.
maxDuration = value ?? Duration.zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdk: ">=3.2.0 <4.0.0"
flutter: ">=3.3.0 <4.0.0"