pretty-print panics #118
Merged
pretty-print panics #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
force-pushed
the
catch-panic
branch
from
8b08689 to
3f28bd4
Compare
|
Does it also have |
|
@yoshuawuyts few quick questions: |
|
@mgattozzi it should work on stable! |
mgattozzi
approved these changes
Apr 30, 2018
There was a problem hiding this comment.
Awesome! Also looks like it grabs meta-data from the Cargo.toml so this LGTM, but @ashleygwilliams will be the one who determines whether she wants this or not!
ashleygwilliams
approved these changes
May 2, 2018
|
great addition @yoshuawuyts ! thanks so much for this <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya!
This PR adds human-panic, a pretty-printer & report generator for panics. I figured since this crate is targeted at Rust folks from all skill levels, it might be useful to make sure that we display friendly messages even if an unexpected error occurs.
I've also opened a sibling issue on
quicli(killercup/quicli#75) to discuss if it might make sense to include by default.Hope this PR is useful!
Refs