misc: remove dead_code allows

Now that everything is wired up, remove the temporary `#[allow(dead_code)]` annotations added in prev. commits.
rustls · Jan 2, 2024 · a3444ce · a3444ce
1 parent d9f2afd
commit a3444ce
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 9 deletions.
diff --git a/rustls/src/client/client_conn.rs b/rustls/src/client/client_conn.rs
@@ -421,7 +421,6 @@ pub enum Tls12Resumption {
 ///
 /// Note: differs from the protocol-encoded EchConfig (`EchConfigMsg`).
 #[derive(Clone, Debug)]
-#[allow(dead_code)] // TODO(@cpu): remove in subsequent commit.
 pub struct EchConfig {
  /// The provider to use for HPKE operations.
  pub(crate) hpke_provider: &'static dyn HpkeProvider,
@@ -495,7 +494,6 @@ impl EchConfig {
  })
  }
 
- #[allow(dead_code)] // TODO(@cpu): remove in subsequent commit.
  pub(crate) fn hpke_info(&self) -> Vec<u8> {
  // "tls ech" || 0x00 || ECHConfig
  // https://datatracker.ietf.org/doc/html/draft-ietf-tls-esni-17#section-6.1

diff --git a/rustls/src/hash_hs.rs b/rustls/src/hash_hs.rs
@@ -60,7 +60,6 @@ impl HandshakeHashBuffer {
 
  /// Fork the hash computation, producing another context that has the
  /// same prefix as this one.
- #[allow(dead_code)] // TODO(@cpu): remove in subsequent commit.
  pub(crate) fn get_fork(&self) -> Self {
  Self {
  buffer: self.buffer.clone(),
@@ -134,7 +133,6 @@ impl HandshakeHash {
 
  /// Fork the hash computation, producing another context that has the
  /// same prefix as this one.
- #[allow(dead_code)] // TODO(@cpu): remove in subsequent commit.
  pub(crate) fn get_fork(&self) -> Self {
  Self {
  provider: self.provider,

diff --git a/rustls/src/msgs/handshake.rs b/rustls/src/msgs/handshake.rs
@@ -1169,7 +1169,6 @@ impl HelloRetryRequest {
  }
  }
 
- #[allow(dead_code)] // TODO(@cpu): remove in subsequent commits.
  pub(crate) fn get_ech_retry_request(&self) -> Option<&Vec<u8>> {
  let ext = self.find_extension(ExtensionType::EncryptedClientHello)?;
  match *ext {
@@ -1223,7 +1222,6 @@ pub(crate) enum Purpose {
  /// Standard RFC 8446 encoding.
  Standard,
  /// Encoding for ECH confirmation.
- #[allow(dead_code)] // TODO(@cpu): Remove in subsequent commits.
  EchConfirmation,
 }
 
@@ -2437,7 +2435,6 @@ pub struct EchConfigContents {
  pub extensions: Vec<EchConfigExtension>,
 }
 
-#[allow(dead_code)] // TODO(@cpu): Remove in subsequent commits.
 impl EchConfigContents {
  /// Returns true if there is more than one extension of a given
  /// type.

diff --git a/rustls/src/tls13/key_schedule.rs b/rustls/src/tls13/key_schedule.rs
@@ -213,7 +213,6 @@ impl KeyScheduleHandshakeStart {
  new
  }
 
- #[allow(dead_code)] // TODO(@cpu): remove in subsequent commit.
  pub(crate) fn server_ech_confirmation_secret(
  &mut self,
  client_hello_inner_random: &[u8],
@@ -822,7 +821,6 @@ fn hkdf_expand_label_slice(
  })
 }
 
-#[allow(dead_code)] // TODO(@cpu): remove in subsequent commit.
 pub(crate) fn server_ech_hrr_confirmation_secret(
  hkdf_provider: &'static dyn Hkdf,
  client_hello_inner_random: &[u8],