Add inline tags to commonly used functions #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone through and added inline to some commonly used functions.
If everyone is happy, we could also add these to others.
We should judge what should be inlined. See https://nnethercote.github.io/perf-book/inlining.html
None. The compiler will decide itself if the function should be inlined. This will depend on the optimization level, the size of the function, etc. If you are not using link-time optimization, functions will never be inlined across crates.
#[inline]. This suggests that the function should be inlined, including across crate boundaries.
Amazingly I saw great wins with just this, as I have to call some of these functions a lot when encoding a lot of data.
This is using lto:
before
after: