Derive/implement Debug for Config and AndroidLogger
#81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Sep 5, 2024
| /// Create a new logger with default config | ||
| fn default() -> AndroidLogger { | ||
| AndroidLogger { | ||
| config: OnceLock::from(Config::default()), |
There was a problem hiding this comment.
This is what Default already does on OnceLock. Since that's the only member, we can simply have #[derive(Default)] struct AndroidLogger ....
MarijnS95
commented
Sep 5, 2024
|
@MarijnS95 Let me know when you are ready to merge, ping me. |
|
@Nercury thanks, I think this is ready for review. The only open comment was meant for educational purposes to reviewers (to understand why I was making a drive-by change), not something that still needs to change it seems 🙂 |
|
Whoops, merge conflict. |
Allows these structs to be printed, useful for supposedly the `log4rs` crate which requires this to be implemented on `AndroidLogger`.
MarijnS95
force-pushed
the
marijn/unconditionally-derive-debug
branch
from
b98be74 to
cac592f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
Allows these structs to be printed, useful for supposedly the
log4rscrate which requires this to be implemented onAndroidLogger.