Rename [assign.custom-welcome-messages]
and it's fields
#2113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames (while keeping compatibility for the names)
[assign.custom-welcome-messages]
and it's fields to:Old syntax
This is done in order to be less confusing to users as "welcome" can be confused with a first time welcome message instead of the meaning we use, namely the welcome message of the PR. I also took the opportunity to clarify the fields meaning (in particular regarding manual-assign).
Reported at rust-lang/miri#4472 (comment).
Only the last commit is relevant.