-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - AArch64 Big Endian Intrinsics #1708
base: master
Are you sure you want to change the base?
Fix - AArch64 Big Endian Intrinsics #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however there still seems to be some CI failures.
027b28b
to
a6958f0
Compare
The pipeline should now be fixed, though it currently fails due to: The PR is also significantly smaller, as we've isolated the intrinsics that require Additionally, I've cleaned up the currently non-functional CI code in |
Looks like the pipeline is fixed by; #1719 I'm not sure how to re-run this pipeline? |
a6958f0
to
e4f37d6
Compare
e4f37d6
to
fbe5fce
Compare
AArch64 Big Endian Intrinsics
Automatic generation of AArch64 big endian intrinsics with the new generator. The generated intrinsics are conceptually similar to those in
arm_neon.h
, utilizingsimd_shuffle!(...)
to reorder bits as required.Testing was performed using the
intrinsic-test
program, confirming that the generated big-endian intrinsics produce the same results as theirclang
counterparts.This PR includes updates to
run.sh
and a newDockerfile
. However, I have not integrated these changes into the CI pipeline because buildingrustc
currently requires modifications to memchr - see here.With the changes in this PR, it should be possible to build
memchr
again, thereby enablingaarch64_be-unknown-linux-gnu
as a Rust target without requiring pre-modifications to memchr during the rustc build process.Closes: #1484