Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: do not inline x86 instrinsics into x86-64 #1656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

notriddle
Copy link

This reduces the size of the core/arch HTML from about 187M to 132M.

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

This reduces the size of the `core/arch` HTML from about
187M to 132M.
@notriddle notriddle force-pushed the notriddle/doc-no_inline-x86_64 branch from 988350f to 926b559 Compare October 8, 2024 19:22
@Amanieu
Copy link
Member

Amanieu commented Oct 31, 2024

While this does reduce the size, it actually makes the documentation incorrect: std::arch::x86 can't be accessed from x86-64: you need to use std::arch::x86_64 instead.

@notriddle
Copy link
Author

I can remove the incorrect cfg(any()) part, but is the change to an explicitly-visible glob import acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants