style: migrate the codebase to let-chains
#4397
Open
+191
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jun 28, 2025
src/download/mod.rs
Outdated
| } | ||
| } | ||
| let prefix = "content-length: "; | ||
| if let Ok(data) = str::from_utf8(header) |
There was a problem hiding this comment.
This is cool and stuff but I feel like it would be more readable as a series of early returns with let-else.
There was a problem hiding this comment.
@djc I think the new version is a bit error prone because it repeats the default return value true so many times. What do you think?
PS: It's quite unfortunate that we can't use let-chains with let-else yet...
rami3l
force-pushed
the
chore/clippy
branch
2 times, most recently
from
b74a780 to
646a41b
Compare
rami3l
changed the title
clippy warningslet-chains
rami3l
changed the title
let-chainslet-chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has mainly converted the old code to use the new
let-chainsthanks to theclippy::collapsible_iflint. The overall readability seems to have been improved in a bunch of places.