Skip to content

test(cli-inst-interactive): migrate to .expect() APIs #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

test(cli-inst-interactive): migrate to .expect() APIs #4353

merged 1 commit into from
Jun 2, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jun 1, 2025 •
edited
Loading

Part of #4359.

SemanticDiff

@rami3l rami3l mentioned this pull request Jun 1, 2025
Merged
3 tasks
@rami3l rami3l requested a review from Copilot June 2, 2025 02:45
Copilot
Copilot AI reviewed Jun 2, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates tests in the CLI interactive component to the new .expect() APIs. The key changes include introducing a new export (Assert) and reordering the public exports in src/test.rs to support the API migration.

@rami3l rami3l mentioned this pull request Jun 2, 2025
Open
@rami3l rami3l marked this pull request as ready for review June 2, 2025 10:04
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

@rami3l: no appropriate reviewer found, use r? to override

@rami3l rami3l added this pull request to the merge queue Jun 2, 2025
Merged via the queue into rust-lang:master with commit ec75fed Jun 2, 2025
29 checks passed
@rami3l rami3l deleted the test/new-api-3 branch June 2, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rami3l @rustbot @djc