Implement incremental caching of object files #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
added
C-enhancement
|
Currently running the rustc-perf suite. Hopefully this makes the incremental benches mostly green too, like the non-incremental benches. |
|
I think something went wrong with the incremental benches. The results for cg_clif are still as horrible as before. |
|
I think it is now correctly benchmarking. I moved the |
|
Posted results in https://github.com/bjorn3/rustc_codegen_cranelift/issues/878#issuecomment-597871730. tl;dr: most incremental benchmarks are now faster with cg_clif than with cg_llvm, but there are still regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only enabled when the
CG_CLIF_INCR_CACHEenv var is set to prevent accidentally caching object files in the incremental cache while modifying cg_clif. Otherwise it would be necessary to completely disable the incremental cache during development, which makes the sysroot build much slower.Fixes #760