add llvm.x86.sse2.cvtps2dq
#1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Jun 6, 2024
Comment on lines
+462
to
+464
| let value = fx.bcx.ins().x86_cvtt2dq(types::I32X4, a); | ||
| let cvalue = CValue::by_val(value, ret.layout()); | ||
| ret.write_cvalue(fx, cvalue); |
There was a problem hiding this comment.
hopefully this is sort of idiomatic. It's weird that cvtt2dq got its own special instruction in cranelift but cvt2dq did not.
There was a problem hiding this comment.
I guess only cvtt2dq was necessary for implementing the wasm simd support.
|
Thanks! I'm currently trying to completely rework the way vendor intrinsics are implemented. I don't know if it will work out yet, but maybe hold off on implementing other intrinsics for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1492, but some further intrinsics are needed for the
tiny_skiatest suite to pass with cranelift:nonetheless, this addition makes 26 more tests pass