Full abi compatibilty #1131
Merged
Full abi compatibilty #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check wasn't very useful and removing it simplifies the code.
This ensures that all stack slots are aligned to 16 bytes. Without this linking against crates compiled with cg_llvm may cause a crash due to simd instructions requiring a 16 byte alignment.
bjorn3
added
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several cases of crashes when interfacing with C code. In addition this will make it possible to build dependencies using cg_llvm with optimizations and only build the user program using cg_clif. While I haven't yet added support to the build system for this, I have manually confirmed that building simple-raytracer against the cg_llvm sysroot works. (albeit resulting in a somewhat slower executable for some reason) I have also confirmed that linking bevymark against a cg_llvm compiled bevy works.
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/10. This is the oldest currently open issue and the last open issue I assigned to the MVP milestone back in August 2018.
Should help with https://github.com/bjorn3/rustc_codegen_cranelift/issues/381
Should help with https://github.com/bjorn3/rustc_codegen_cranelift/issues/977
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1092
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1129