Remove properly tracked config file from .gitignore & add support for skipping of link-checking #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the reason this is ignored is that we often want to change |
marxin
force-pushed
the
book.toml-remove-from-gitignores
branch
from
af3a314
to
5b5c220
Compare
marxin
changed the title
|
Sure, that makes sense and I've just added the support. What do you think about it now? |
The file is part of the git history and is a configuration file. Fixes: rust-lang#2018
marxin
force-pushed
the
book.toml-remove-from-gitignores
branch
from
5b5c220
to
9667f99
Compare
|
@camelid May I please ping this? |
jieyouxu
added
the
S-waiting-on-review
jieyouxu
added
A-meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file is part of the git history and is a configuration file.
Fixes: #2018