Rename the diagnostic item for std::sync::mpsc::Receiver#155854
Open
cammeresi wants to merge 1 commit intorust-lang:mainfrom
Open
Rename the diagnostic item for std::sync::mpsc::Receiver#155854cammeresi wants to merge 1 commit intorust-lang:mainfrom
std::sync::mpsc::Receiver#155854cammeresi wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Contributor
Author
|
Due to multiple misunderstandings, what I said last time about the Receiver's item being in use was not actually correct. If I'm wrong, the tests should point it out, right? |
Contributor
|
I see it's used at There may not be tests that actually exercise it, though. |
Contributor
|
To keep that clippy code the same you also have to update the symbol there. |
mejrs
added
S-waiting-on-author
cammeresi
force-pushed
the
20260426-receiver-diag
branch
from
cb7b4e4 to
87efd5f
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Contributor
Author
|
I wasn't sure how wide a net to cast since |
This comment has been minimized.
This comment has been minimized.
`MpscReceiver` aligns with `MpscSender`. The original name appears to not actually have been in use, for better or worse. Along the way, sprinkle the attribute onto `mpmc::Receiver` and `mpmc::Sender` too.
cammeresi
force-pushed
the
20260426-receiver-diag
branch
from
87efd5f to
04874be
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MpscReceiveraligns withMpscSender. The original name appears to not actually have been in use, for better or worse.r? mejrs