Skip to content

replace <name> @ ty::AliasTy matches with just using args: <name>_args#155150

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WilliamTakeshi:alias-ty-args-binding
Apr 12, 2026
Merged

replace <name> @ ty::AliasTy matches with just using args: <name>_args#155150
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WilliamTakeshi:alias-ty-args-binding

Conversation

@WilliamTakeshi
Copy link
Copy Markdown
Contributor

@WilliamTakeshi WilliamTakeshi commented Apr 11, 2026

ref #154941

replace <name> @ ty::AliasTy matches with just using args: <name>_args

I updated all occurrences where @ ty::AliasTy became unnecessary after the change. In cases where both forms are still used, no changes were made.

r? @WaffleLapkin

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 11, 2026

Some changes occurred in exhaustiveness checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 11, 2026

WaffleLapkin is not on the review rotation at the moment.
They may take a while to respond.

Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in most places changed here, args is unambiguous enough, at the very least in smaller function. Could you change args: <name>_args to just args in such places?

View changes since this review

Comment thread compiler/rustc_pattern_analysis/src/rustc.rs Outdated
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026
@WilliamTakeshi
Copy link
Copy Markdown
Contributor Author

WilliamTakeshi commented Apr 11, 2026

@rustbot ready

@WaffleLapkin I pushed 2 more commits. In these cases, what do you prefer? squash everything in one and force push or keep in diff commits? Thanks!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 11, 2026
Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We generally prefer squashing commits, so, yes, please do that :)

View changes since this review

@WilliamTakeshi
Copy link
Copy Markdown
Contributor Author

@bors squash msg="replace @ ty::AliasTy matches with just args"

@rust-bors

This comment has been minimized.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 11, 2026

🔨 3 commits were squashed into a133bb8.

@rust-bors rust-bors Bot force-pushed the alias-ty-args-binding branch from 7a2cf2b to a133bb8 Compare April 11, 2026 18:00
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 12, 2026

@bors r=WaffleLapkin,Kivooeo

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 12, 2026

📌 Commit a133bb8 has been approved by WaffleLapkin,Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 12, 2026

@bors rollup

rust-bors Bot pushed a commit that referenced this pull request Apr 12, 2026
Rollup of 7 pull requests

Successful merges:

 - #155084 (Initial functions to start on transmute v2)
 - #155126 (add `cfg(target_object_format = "...")`)
 - #155165 (Portable SIMD subtree update)
 - #153871 (fix spurious test failure in `metadata_access_times`)
 - #155150 (replace <name> @ ty::AliasTy matches with just using args: <name>_args)
 - #155159 (Fix min-specialization ICE from ignored region resolution failure)
 - #155167 (Reduce size of `ImportData`)
@rust-bors rust-bors Bot merged commit 6d7015c into rust-lang:main Apr 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 12, 2026
rust-timer added a commit that referenced this pull request Apr 12, 2026
Rollup merge of #155150 - WilliamTakeshi:alias-ty-args-binding, r=WaffleLapkin,Kivooeo

replace <name> @ ty::AliasTy matches with just using args: <name>_args

ref #154941

replace `<name> @ ty::AliasTy` matches with just using `args: <name>_args`

I updated all occurrences where <name> @ ty::AliasTy became unnecessary after the change. In cases where both forms are still used, no changes were made.

r? @WaffleLapkin
@WilliamTakeshi WilliamTakeshi deleted the alias-ty-args-binding branch April 12, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants