Skip to content

test(chore): audit //@ run-pass in ui tests#154254

Open
Embers-of-the-Fire wants to merge 27 commits intorust-lang:mainfrom
Embers-of-the-Fire:chore/clean-test-run-pass
Open

test(chore): audit //@ run-pass in ui tests#154254
Embers-of-the-Fire wants to merge 27 commits intorust-lang:mainfrom
Embers-of-the-Fire:chore/clean-test-run-pass

Conversation

@Embers-of-the-Fire
Copy link
Contributor

@Embers-of-the-Fire Embers-of-the-Fire commented Mar 23, 2026 •
edited
Loading

Part of work for #154158. The list is non-exhausive and there's definitely parts that I can/will not cover.

Note: still working here with around ~1000 tests to audit and finished ~400 files. Do not merge this but could be reviewed now :)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 23, 2026
@Embers-of-the-Fire Embers-of-the-Fire changed the title text(chore): audit //@ run-pass in ui tests test(chore): audit //@ run-pass in ui tests Mar 23, 2026
@Embers-of-the-Fire Embers-of-the-Fire marked this pull request as ready for review March 23, 2026 16:23
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 14 candidates

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 23, 2026 •
edited
Loading

@rustbot reroll
I'm very busy in my personal life this week and probably the next one as well so will leave review duty for a bit (just changed my triagebot config)

@rustbot rustbot assigned TaKO8Ki and unassigned JonathanBrouwer Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TaKO8Ki TaKO8Ki

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Embers-of-the-Fire @rustbot @JonathanBrouwer @TaKO8Ki