Remove a couple of unnecessary flags and env vars in bootstrap #151745
Conversation
rustbot
added
S-waiting-on-review
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
|
||
| // Environment variables *required* throughout the build | ||
| // | ||
| // FIXME: should update code to not require this env var |
There was a problem hiding this comment.
Should this FIXME be moved/removed, or does 'this env var' refer to all of these? 🤔
There was a problem hiding this comment.
I believe it also refers to CFG_COMPILER_BUILD_TRIPLE and maybe CFG_RELEASE_CHANNEL.
There was a problem hiding this comment.
I just went through the history. This fixme originates from the initial commit of the rust version of the build system and back then only applied to CFG_COMPILER_HOST_TRIPLE. The other env vars didn't exist yet. As such I removed the todo.
|
LGTM, but it could be good to update the fixme to 'these env vars' if that's appropriate; r=me when green with or without |
This lint is allowed by default nowadays.
Rustc no longer depends on winapi. Only cg_clif, cg_gcc and rustfmt still use it, none of which are libraries to compile against. And in case of both cg_clif and cg_gcc it never ends up in an artifact we ship. For cg_clif it only shows up when the jit mode is enabled, which is not the case for the version we ship. For cg_gcc it is used by a test executable, which isn't shipped either.
These flags should be available on the bootstrap compiler.
bjorn3
force-pushed
the
remove_unnecessary_flags
branch
from
e0b76a3 to
257ea3b
Compare
|
Removed the |
3 participants
No description provided.