Skip to content

Conversation

cjgillot
Copy link
Contributor

r? @ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2025
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 19, 2025
Stop invalidating CFG caches in CleanupPostBorrowck.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 19, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 19, 2025

☀️ Try build successful (CI)
Build commit: 1dca6da (1dca6dac708cb5656f6a9c08e3a061e5bc299583, parent: 6380899f32599ea25615d4ccd708d0e8da652b0c)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1dca6da): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.3%, -0.1%] 4
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -7.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-7.8% [-7.8%, -7.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -7.8% [-7.8%, -7.8%] 1

Cycles

Results (secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.9% [1.7%, 2.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.955s -> 472.072s (0.02%)
Artifact size: 390.54 MiB -> 390.52 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 19, 2025
@cjgillot cjgillot marked this pull request as ready for review October 19, 2025 15:34
@rustbot
Copy link
Collaborator

rustbot commented Oct 19, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2025
@cjgillot
Copy link
Contributor Author

r? compiler

Copy link
Contributor

@tmiasko tmiasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. r=me with commits squashed.

View changes since this review

@tmiasko tmiasko assigned tmiasko and unassigned jackh726 Oct 20, 2025
@cjgillot
Copy link
Contributor Author

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented Oct 20, 2025

📌 Commit 6abc50b has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2025
@bors
Copy link
Collaborator

bors commented Oct 21, 2025

⌛ Testing commit 6abc50b with merge 63dcdf7...

@bors
Copy link
Collaborator

bors commented Oct 21, 2025

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 63dcdf7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2025
@bors bors merged commit 63dcdf7 into rust-lang:master Oct 21, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 21, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c7a635f (parent) -> 63dcdf7 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 63dcdf7ca89f4f547030823573f4a2ebeae1cc48 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2475.8s -> 3041.1s (22.8%)
  2. pr-check-1: 1497.6s -> 1743.6s (16.4%)
  3. dist-apple-various: 3489.9s -> 4019.5s (15.2%)
  4. x86_64-gnu-llvm-20: 2411.1s -> 2759.7s (14.5%)
  5. i686-gnu-1: 7358.8s -> 8383.8s (13.9%)
  6. aarch64-gnu-llvm-20-1: 3437.1s -> 3914.0s (13.9%)
  7. arm-android: 5466.6s -> 6189.0s (13.2%)
  8. aarch64-gnu-llvm-20-2: 2185.4s -> 2448.8s (12.1%)
  9. x86_64-gnu-gcc: 3014.3s -> 3362.9s (11.6%)
  10. dist-aarch64-apple: 6365.4s -> 7094.3s (11.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants